Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/show ratings in profile #165

Merged
merged 5 commits into from
Sep 22, 2024
Merged

Conversation

feliperamoss
Copy link
Collaborator

No description provided.

Felipe Pedroso Ramos added 3 commits September 22, 2024 16:19
@feliperamoss feliperamoss self-assigned this Sep 22, 2024
@feliperamoss feliperamoss linked an issue Sep 22, 2024 that may be closed by this pull request
@feliperamoss feliperamoss marked this pull request as draft September 22, 2024 17:00
@feliperamoss feliperamoss marked this pull request as ready for review September 22, 2024 17:50
@Maxiboy441
Copy link
Owner

Hey @feliperamoss,
please check this error "Argument type 'System.Tuple<string,string?,string,string,string>' is not assignable to model type 'System.Tuple<string,string,string,string,System.Tuple<string,string>,string>'" in the UserUpdate view

Copy link
Owner

@Maxiboy441 Maxiboy441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Owner

@Maxiboy441 Maxiboy441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, is it supposed to go "on-click" of a movie to its page or open like in the other tabs from the side?

And when you change you rating from the my space, the window stays open after selection, is that intended?

@feliperamoss
Copy link
Collaborator Author

feliperamoss commented Sep 22, 2024

Hey, is it supposed to go "on-click" of a movie to its page or open like in the other tabs from the side?

And when you change you rating from the my space, the window stays open after selection, is that intended?

It was very buggy to leave the side card for the rating tab and the rating after submit was also intended to show the modal after selection, so if user clicks by accident he/she does not need to open the modal to edit again.

@Maxiboy441 Maxiboy441 merged commit e8e2296 into develop Sep 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ratings to MySpace
2 participants